Admin UI and minor fixes #469
Conversation
marsian83
commented
Oct 23, 2023
marsian83
commented
…t import for index.css
| const benchmarkWorkloads = [ | ||
| "OLTP-SET", | ||
| "OLTP-READONLY", | ||
| "OLTP-READONLY-OLAP", | ||
| "TPCC", | ||
| "OLTP", | ||
| ]; |
There was a problem hiding this comment.
Can we make this list dynamic based on the list of benchmarks returned by the API?
There was a problem hiding this comment.
Can we make this list dynamic based on the list of benchmarks returned by the API?
I thnk I know how to do this
func (s *Server) getBenchmarkNames(c *gin.Context) {
c.JSON(http.StatusOK, gin.H{
"benchmarks": s.benchmarkTypes,
})
}This code snippet if added in go/server and adding a respective route like /api/get-benchmark-types
Will give list which we can use in frontend.
@frouioui
website/src/pages/AdminBenchmarksPage/components/ExecutionQueue.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| export default function AdminPanelPage() { |
| import { Link } from "react-router-dom"; | ||
|
|
| @@ -0,0 +1,87 @@ | |||
| import React, { useEffect, useState } from "react"; | |||
| // import api from "../../services/api"; | ||
|
|
| import Macrobench from "../common/Macrobench"; | ||
| import { BenchmarkStatus } from "./enums"; |
| export interface Macros { | ||
| OLTP: MacroBenchmark[] | null; |
There was a problem hiding this comment.
same thing here as mentioned above, would it be possible to dynamically load the name of the macro benchmarks? the list of macro benchmark evolve over time
|
Hey @frouioui @marsian83 does this need any help, I'd be happy to take this up and bring it to at least a completion! |
|
@codingmickey Hello! I don't think @marsian83 has planned on continuing this given there was no response for months. You're welcome to take this on! |
Hi, it'd be great if you could honestly. |
|
Hi @codingmickey |
|
Sure anyways I have viva exam today and on Monday 😅
…On Fri, 10 May, 2024, 10:46 pm Spandan Barve, ***@***.***> wrote:
Hi @codingmickey <https://github.com/codingmickey>
I see there are a lot of conflicts with the current state of the HEAD and
the main
let me resolve these conflicts first before you could look into this
Mind waiting a day or two?
—
Reply to this email directly, view it on GitHub
<#469 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKEMS6Y3PN2PTS3W5XEA4R3ZBT6H3AVCNFSM6AAAAAA6MSXZQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHE4DGMRSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
- Macrobench - Daily - Compare
|
Hi, I made progress for this @frouioui @marsian83 Can you please guide me aroudn this github issue? |
You can fork my branch and then create PR to it, when I merge those, it will be added here. |
|
I have fixed all pages |
| @@ -138,73 +138,73 @@ export default function Macrobench(props: MacrobenchProps) { | |||
| left={fixed(data.diff.Left.Result.threads, 2)} | |||
| right={fixed(data.diff.Right.Result.threads, 2)} | |||
| diffMetric={fixed(data.diff.Diff.threads, 2)} | |||
| /> | |||
| /> */} | |||
There was a problem hiding this comment.
Why have you commented out these sections?
There was a problem hiding this comment.
the response returned by api does not have specific values that correspond to these .This is the reason they are commented out.
website/src/hooks/useApiCall.ts
Outdated
| @@ -23,6 +23,7 @@ export default function useApiCall<T extends ApiEndpoint>( | |||
| }, | |||
| ...config, | |||
| }); | |||
| console.log(`Response from ${uri}:`, response.data); | |||
There was a problem hiding this comment.
Please remove any unused / unnecessary console logs
| @@ -20,11 +20,11 @@ import PropTypes from "prop-types"; | |||
| import { fixed, formatByteForGB } from "../../../utils"; | |||
| import { Link } from "react-router-dom"; | |||
|
|
|||
| export default function SearchMacro({ data, gitRef }: any) { | |||
| export default function SearchMacro({ data, macroName, gitRef }: any) { | |||
There was a problem hiding this comment.
Can you figure out how to do this without explicitly using any
|
I have reviewed your code @harry-sandhu |
Co-authored-by: Florent Poinsard <[email protected]> Signed-off-by: Spandan Barve <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]> Signed-off-by: Spandan Barve <[email protected]>
|
I will close this as @Jad31 is going to do the admin UI again. |
